-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-5029: CTAs should initialize in dark mode preference #1251
Conversation
✅ Deploy Preview for mongodb-snooty ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really does look great. Okay, I know this is so annoying, but since we're doing this anyway - could you also do the :before: and the svg so that those colors don't flash in light mode too?
And there's one odd thing happening... in the first link, the "You are" initialize in dark blue... I'm somehow guessing it's because of the anchor tag, but I really am not sure!
Hey Maya, I noticed 3 small things in the that maybe could be fixed but Im not sure if they are blockers or not
Update: I noticed Matt also commented on the 1st point so you can ignore that one. |
@biancalaube the behavior seems to happen in preprd as well, so I'm going to file a ticket for this! edit: nvm seung just filed one |
Thanks for doing that Maya, LGTM! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh so beautiful
Stories/Links:
DOP-5029
Updates
Banner.js
andCTABanner.js
.Current Behavior:
CTA Banner
App Services Deprecation
Staging Links:
CTA Banner
Test Banner Page
App Services Deprecation
Notes:
README updates